Modified export function to avoid change of attribute names, and added test about fill values #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…very time a nansat object was opened
… I've changed it to a debug message.
…he export function instead
… issue when fill values are not correctly picked up
…ute names without 'GDAL_'
mortenwh
commented
Jan 4, 2023
Comment on lines
+34
to
+38
| try: | ||
| import xarray as xr | ||
| except: | ||
| warnings.warn("'xarray' needs to be installed for Exporter.xr_export to work.") | ||
|
|
mortenwh
commented
Jan 4, 2023
| @@ -18,6 +18,7 @@ | |||
| import tempfile | |||
| import datetime | |||
| import warnings | |||
| import importlib | |||
mortenwh
commented
Jan 4, 2023
| NetCDF file name | ||
| """ | ||
| # Open new file to edit variable names | ||
| ds = Dataset(filename, 'r+') |
mortenwh
commented
Jan 4, 2023
| del_attrs = [] | ||
| rename_attrs = [] | ||
| # Open new file to edit attribute names | ||
| ds = Dataset(filename, 'r+') |
…'CF-1.5' which is obviously wrong. This is now deleted. Same goes for the history. That should also be handled in the processing software rather then by the gdal netcdf driver.
In addition to the above, can you pleae fix the following error:FAIL: test_export2thredds_longlat_dict (nansat.tests.test_exporter.ExporterTest)Traceback (most recent call last): Ran 284 tests in 19.624s FAILED (failures=1) |
|
I could do all these changes myself in the branch https://github.com/nansencenter/nansat/tree/issue525-new-export |
|
Changes addressed in #528 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should close #525